Skip to content

MNT: Warn on using pixel marker for scatter() #29342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2024
Merged

MNT: Warn on using pixel marker for scatter() #29342

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ff0600
MNT: Warn on using pixel marker for scatter()
timhoffm Dec 18, 2024
0d28220
Update lib/matplotlib/axes/_axes.py
timhoffm Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/matplotlib/axes/_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4938,6 +4938,12 @@
marker_obj = marker
else:
marker_obj = mmarkers.MarkerStyle(marker)
if cbook._str_equal(marker_obj.get_marker(), ","):
_api.warn_external(

Check warning on line 4942 in lib/matplotlib/axes/_axes.py

View check run for this annotation

Codecov / codecov/patch

lib/matplotlib/axes/_axes.py#L4942 

Added line #L4942 was not covered by tests
"The pixel maker ',' is not supported on scatter(); using "
"a finite-sized square instead, which is not necessarily 1 pixel in "
"size. Use the square marker 's' instead to suppress this warning."
)

path = marker_obj.get_path().transformed(
marker_obj.get_transform())
Expand Down
Loading