Skip to content

DOC: change wording on new contributor path #29377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

tacaswell
Copy link
Member

No description provided.

@tacaswell tacaswell added this to the v3.11.0 milestone Dec 23, 2024
@github-actions github-actions bot added the Documentation: devdocs files in doc/devel label Dec 23, 2024
Copy link
Member

@rcomer rcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording looks good but the -- renders as is. Is that intentional?

@tacaswell
Copy link
Member Author

I was hoping this would become emdashes when rendered. We appear to have explicitly turned them off:

matplotlib/doc/conf.py

Lines 618 to 619 in 80bc1ac

# Use typographic quote characters.
smartquotes = False
via aae1b6e

I fixed the two I added and one other in this file.

@tacaswell
Copy link
Member Author

tacaswell commented Dec 23, 2024

Ah, the context is #11562 which was messing up quotation marks.

[edited to fix copy-paste error with link to PR not the codebase again]

@rcomer rcomer merged commit c2d502d into matplotlib:main Dec 23, 2024
22 checks passed
@tacaswell tacaswell deleted the doc/tweak_new-contributor branch December 23, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: devdocs files in doc/devel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants