MNT: Remove *args for OffsetBox.__init__() #29386
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*args were passed on to Artist.__init__(), but Artist does not accept any positional parameters. Passing any positional parameters to Offsetbox would thus have always failed internally. It is thus clearer to not accept any positional parameters for OffsetBox in the first place .
480c54f to
c855d76
Compare
rcomer
approved these changes
Dec 30, 2024
story645
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*args were passed on to
Artist.__init__(), but Artist does not accept any positional parameters. Passing any positional parameters toOffsetBoxwould thus have always failed internally. It is clearer to not accept any positional parameters forOffsetBoxin the first place.