FIX: get_tick_position() should disregard major/minor ticks that are not drawn #29388
+41
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcomer
reviewed
Jan 5, 2025
Closes matplotlib#21337 by ignoring major/minor ticks, if they are not used because of a NullLocator.
8c17623 to
ea16190
Compare
I don't really care. Bug fixes can break someone if they rely on the buggy behavior. I generally wouldn't make any guarantees on unintended behavior, but OTOH it doesn't harm if this fix waits a couple of months longer until rolled out. |
rcomer
approved these changes
Jan 5, 2025
scottshambaugh
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21337 by ignoring major/minor ticks, if they are not used because of a NullLocator.