Skip to content

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Jan 5, 2025

I've stumbled over this when reading the instructions. While this is in the section "Install external dependencies", I was unclear whether that link would go to / cover the whole doc dependencies. Stating that these are only the "external tools for the documentation build" is a bit clearer.

@github-actions github-actions bot added the Documentation: devdocs files in doc/devel label Jan 5, 2025
@timhoffm timhoffm added this to the v3.11.0 milestone Jan 5, 2025
@story645
Copy link
Member

story645 commented Jan 5, 2025

In general I think external tools is ill defined (b/c it can be system tools, apps, libraries, etc) and that's why all the docs around external tools are clunky.

I've stumbled over this when reading the instructions. While this is in
the section "Install external dependencies", I was unclear whether that
link would go to / cover the whole doc dependencies. Stating that these
are only the "external tools for the documentation build" is a bit
clearer.
@timhoffm
Copy link
Member Author

timhoffm commented Jan 5, 2025

In general I think external tools is ill defined (b/c it can be system tools, apps, libraries, etc) and that's why all the docs around external tools are clunky.

I have the feeling that "external" is not a good term here - external to what? - and what would be "internal". Maybe "non-Python tools" would be a better term?

@story645
Copy link
Member

story645 commented Jan 6, 2025

As far as I remember, it's the set of things that can't/shouldn't be conda/pip installed.

@timhoffm
Copy link
Member Author

timhoffm commented Jan 6, 2025

Reading the relevant sections again

https://matplotlib.org/devdocs/devel/development_setup.html#install-external-dependencies and
https://matplotlib.org/devdocs/install/dependencies.html#dependencies

I’m ok with how “external “ is used. This PR is in line with our current use of that terminology. If you want to fundamentally bike-shed that terminology, please open a separate issue/PR.

@timhoffm timhoffm merged commit c14b1b8 into matplotlib:main Jan 6, 2025
22 checks passed
@timhoffm timhoffm deleted the doc-dev branch January 6, 2025 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: devdocs files in doc/devel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants