MNT: Turn Axes._axis_map into a static dict instead of a property #29424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The axes (self.xaxis, self.yaxis) cannot be changed at run time. Therefore, we don't have to recompute the _axis_map on every access. Instead, we can do this once after `_init_axis()` and store the resulting dict.
WeatherGod
approved these changes
Jan 7, 2025
greglucas
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The axes (
self.xaxis,self.yaxis) as well as their names (self._axis_names) cannot be changed at run time. Therefore, we don't have to recompute the_axis_mapon every access. Instead, we can do this once after_init_axis()and store the resulting dict.