Skip to content

ci: Fix cache key for Matplotlib data #29497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2025
Merged

ci: Fix cache key for Matplotlib data #29497

merged 1 commit into from
Jan 21, 2025

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jan 21, 2025

PR summary

All the others key off matrix.os, but this cache used runner.os, which doesn't key off the architecture, so Ubuntu x86_64 and arm were cross-contaminated.

PR checklist

@QuLogic
ci: Fix cache key for Matplotlib data
5f7cb7f 
All the others key off `matrix.os`, but this cache used `runner.os`,
which doesn't key off the architecture, so Ubuntu x86_64 and arm were
cross-contaminated.
@QuLogic QuLogic added the CI: testing CI configuration and testing label Jan 21, 2025
@tacaswell tacaswell merged commit 2b3eea5 into matplotlib:main Jan 21, 2025
44 checks passed
@QuLogic QuLogic deleted the arm-tests branch January 21, 2025 23:03
@QuLogic QuLogic mentioned this pull request Jan 21, 2025
Closed
@QuLogic QuLogic added this to the v3.11.0 milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
CI: testing CI configuration and testing
Projects
None yet
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @timhoffm @tacaswell