DOC: add color sequences reference example #29563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Feb 1, 2025
There was a problem hiding this comment.
I like the style.
I am in two minds whether to add a second plot with a newly registered color sequence or to leave this as a purely reference example of what is available by default.
You can add a sentence that users can register their own sequences as well and point to register. IMHO an example is not too helpful here. The concept "register -> you can query it by name" is straigt forward. The plot itself will not be helpful as you cannot visualize "there's a new element in the registry". That can only be inferred from the associated example code. But as said, the concept is so simple that any example is dilluting the message because of the additional visualization code.
c2ae704 to
20d1900
Compare
|
Did there used to be a Dark1? |
20d1900 to
ae1359e
Compare
timhoffm
approved these changes
Feb 1, 2025
8f08300 to
c0cd916
Compare
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Feb 2, 2025
timhoffm
added a commit
that referenced
this pull request
Feb 2, 2025
…563-on-v3.10.x Backport PR #29563 on branch v3.10.x (DOC: add color sequences reference example)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Introducing the Matplotlib Abacus!
I did not know that the color sequence registry was a thing. Once I did know, the next thing I wanted to know was what sequences are available. This PR adds an example showing all the built in sequences, analogous to the Colormaps reference and List of Named Colors.
I am in two minds whether to add a second plot with a newly registered color sequence or to leave this as a purely reference example of what is available by default.
PR checklist