Ignore ImageMagick deprecation of "convert" command. #29569
Conversation
Ignoring the deprecation warning (present since IM 7.1.1-33, May 2024) is the quickest fix. The proper fix would be to switch to using "magick" everywhere but the command's syntax is a bit different and the CLI usage thus needs to be verified; moreover this would break users with very old installs of imagemagick (unless adding some version sniffing code) although IMv7 has been out since 2016 so that is likely acceptable. (That proper fix likely also needs some fiddling around the special-casing of `rcParams["animation.convert_path"] = "convert"` in ImageMagickBase.bin_path; e.g. should the rcParams be renamed to `"animation.magick_path"` and have "magick" be the special case...)
|
All of the windows failures are download issues on installing system deps (nija via chocolaty on azure and minimamba on appveyor). |
|
Not that it really matters, but does anyone know why the "topic: animation" labeled was auto-removed by a bot? |
|
Not sure, but I have seen some interference when I try to modify labels right after creating a PR. I assume the bot and me are editing in parallel and that's a race condition. |
That label is only applied for matplotlib/.github/labeler.yml Lines 118 to 122 in 77fa369 Unfortunately, it doesn't support preserving manually added labels. You can add the label after the action has run though (but keep in mind it runs on pushes.) |
|
Do we really need the topic autolabeler? |
Ignoring the deprecation warning (present since IM 7.1.1-33, May 2024) is the quickest fix.
The proper fix would be to switch to using "magick" everywhere but the command's syntax is a bit different and the CLI usage thus needs to be verified; moreover this would break users with very old installs of imagemagick (unless adding some version sniffing code) although IMv7 has been out since 2016 so that is likely acceptable. (That proper fix likely also needs some fiddling around the special-casing of
rcParams["animation.convert_path"] = "convert"in ImageMagickBase.bin_path; e.g. should the rcParams be renamed to"animation.magick_path"and have "magick" be the special case...)Closes (in the short term) #29567, although (per the above) a better fix would be welcome, and it would also be nice if this could have been caught by CI... Likely worth a backport too?
PR summary
PR checklist