DOC: Recommend constrained_layout over tight_layout #29584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes matplotlib#17339 by addressing the remaining open issue matplotlib#17339 (comment).
|
Likely yes. Can we go as far as discouraging |
|
According to the User Guide menu, it is already mildly discouraged
|
Mecanerd
reviewed
Feb 27, 2025
Co-authored-by: Mecanerd <joshdonath23@hotmail.com>
jklymak
approved these changes
Feb 27, 2025
|
Well, I'd merge, but merging is blocked by the bot. Which is pretty annoying to be honest. Why do we need a bot to tell us whether we are allowed to merge or not? |
|
We block merging if the label „needs comment/discussion“ is set. IMHO that makes sense because it prevents premature merging when there are still to be discussed aspects. I had set this mover the question whether tight-layout should be formally discouraged. But that‘s also something we can discuss later/separately. My focus in this PR is to guide users by stating preference between tight-layout and constrained-layout. Therefore, I’ve removed the label. |
rcomer
reviewed
Feb 27, 2025
Co-authored-by: Ruth Comer <10599679+rcomer@users.noreply.github.com>
tacaswell
approved these changes
Feb 28, 2025
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Feb 28, 2025
rcomer
added a commit
that referenced
this pull request
Feb 28, 2025
…584-on-v3.10.x Backport PR #29584 on branch v3.10.x (DOC: Recommend constrained_layout over tight_layout)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17339 by addressing the remaining open issue #17339 (comment).