Added elif for taking NumPy Array for imsave #29641
Open
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
timhoffm
reviewed
Feb 18, 2025
| else: | ||
| sm = mcolorizer.Colorizer(cmap=cmap) | ||
| sm.set_clim(vmin, vmax) | ||
| sm.set_clim(vim, vmax) |
timhoffm
reviewed
Feb 18, 2025
| @@ -1586,9 +1586,11 @@ def imsave(fname, arr, vmin=None, vmax=None, cmap=None, format=None, | |||
| # because that's what backend_agg passes, and can be in fact used | |||
| # as is, saving a few operations. | |||
| rgba = arr | |||
| elif arr.ndim == 3 and arr.shape[-1] in (3,4): | |||
There was a problem hiding this comment.
Does this work for shape[-1] == 3? AFAICS, rgba should have the alpha component included eventually?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
The previous implementation did not distinguish between grayscale and RGB(A) images correctly;
What this PR changes:
-->
PR checklist