Skip to content

Add ninja to Python build requirements #29740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
+4 −9
Closed

Add ninja to Python build requirements #29740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c515344
Add ninja to build requirements
dstansby Mar 12, 2025
6856afd
Don't install ninja in system package managers on CI
dstansby Mar 12, 2025
b0153b1
Install ninja in CI
dstansby Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ commands:
graphviz \
inkscape \
lmodern \
ninja-build \
optipng \
texlive-fonts-recommended \
texlive-latex-base \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cygwin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ jobs:
with:
packages: >-
ccache gcc-g++ gdb git graphviz libcairo-devel libffi-devel
libgeos-devel libQt5Core-devel pkgconf libglib2.0-devel ninja
libgeos-devel libQt5Core-devel pkgconf libglib2.0-devel
noto-cjk-fonts
python3${{ matrix.python-minor-version }}-devel
python3${{ matrix.python-minor-version }}-pip
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,6 @@ jobs:
libxcb-render-util0 \
libxcb-xinerama0 \
lmodern \
ninja-build \
pkg-config \
qtbase5-dev \
texlive-fonts-recommended \
Expand Down Expand Up @@ -204,7 +203,7 @@ jobs:
done
# Workaround for https://github.com/actions/runner-images/issues/10984
brew uninstall --ignore-dependencies --force pkg-config@0.29.2
brew install ccache ffmpeg ghostscript gobject-introspection gtk4 imagemagick ninja
brew install ccache ffmpeg ghostscript gobject-introspection gtk4 imagemagick
brew install --cask font-noto-sans-cjk font-noto-sans-cjk-sc inkscape
;;
esac
Expand Down Expand Up @@ -262,7 +261,7 @@ jobs:
python -m pip install --upgrade $PRE \
'contourpy>=1.0.1' cycler fonttools kiwisolver importlib_resources \
packaging pillow 'pyparsing!=3.1.0' python-dateutil setuptools-scm \
'meson-python>=0.13.1' 'pybind11>=2.13.2' \
'meson-python>=0.13.1' 'pybind11>=2.13.2' 'ninja>=1.8.2' \
-r requirements/testing/all.txt \
${{ matrix.extra-requirements }}

Expand Down
4 changes: 0 additions & 4 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,6 @@ stages:
architecture: 'x64'
displayName: 'Use Python $(python.version)'

- bash: |
choco install ninja
displayName: 'Install dependencies'

- bash: |
python -m pip install --upgrade pip
python -m pip install --upgrade -r requirements/dev/build-requirements.txt
Expand Down
1 change: 1 addition & 0 deletions requirements/dev/build-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
pybind11>=2.13.2,!=2.13.3
meson-python
ninja>=1.8.2
setuptools-scm
Loading