Skip to content

Fix PyGObject version pinning in macOS tests #29748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

dstansby
Copy link
Member

PR summary

This fixes pinning PyGObject in the macOS tests - see #29734 (comment) for more context. Without the quotes, the < acts like a pipe.

PR checklist

@jayaddison
Copy link
Contributor

Thanks @dstansby, and my apologies for introducing the bug! Your fix looks good to me so far based on: https://github.com/matplotlib/matplotlib/actions/runs/13819709516/job/38661817676?pr=29748#step:10:285

I am also wondering, though: given that tests passed without the relevant packages installed at all -- could we remove their installation step from the MacOS CI script? It seems it was originally introduced as a workaround to a MacOS 10.12 bug -- so maybe it is no longer required.

(that wasn't what I planned to show with my change; but inadvertently, it seems that's what I did)

@jayaddison
Copy link
Contributor

Ah, no, my mistake; you mentioned that the absence of the packages causes the failing test to be skipped. In that case: let's apply this fix, and continue the investigation into why the version upgrade is blocked.

Copy link
Contributor

@jayaddison jayaddison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jayaddison
Copy link
Contributor

Ah, no, my mistake; you mentioned that the absence of the packages causes the failing test to be skipped. In that case: let's apply this fix, and continue the investigation into why the version upgrade is blocked.

And indeed I can confirm that with my flawed attempt at a fix (38cf554), the test_interactive_backend[toolbar2-MPLBACKEND=gtk4cairo-BACKEND_DEPS=cairo,gi] test, the failed test we're aiming to fix, is skipped on MacOS 14: https://github.com/matplotlib/matplotlib/actions/runs/13800489129/job/38630884101#step:14:311

(sorry for being verbose; I'd like to be transparent and also keep some notes in case I need to pick up again from forgotten context in future)

@dstansby dstansby marked this pull request as ready for review March 13, 2025 09:37
@dstansby dstansby added this to the v3.10-doc milestone Mar 13, 2025
@tacaswell
Copy link
Member

I'm going merge this on my review + @jayaddison review + fixing CI.

@tacaswell tacaswell merged commit d1fb1be into matplotlib:main Mar 13, 2025
40 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 13, 2025
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 13, 2025
@dstansby dstansby deleted the pygobject-version branch March 13, 2025 19:19
dstansby added a commit that referenced this pull request Mar 17, 2025
…748-on-v3.10.1-doc

Backport PR #29748 on branch v3.10.1-doc (Fix PyGObject version pinning in macOS tests)
dstansby added a commit that referenced this pull request Mar 21, 2025
…748-on-v3.10.x

Backport PR #29748 on branch v3.10.x (Fix PyGObject version pinning in macOS tests)
@ksunden ksunden mentioned this pull request May 9, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants