Skip to content

TST: __spec__ (an import-related variable for modules) was added in pyth... #2981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2014
Merged

TST: __spec__ (an import-related variable for modules) was added in pyth... #2981

merged 1 commit into from
Apr 16, 2014

Conversation

cimarronm
Copy link
Contributor

...on 3.4. Need to exclude in test_override_builtins. This addresses issue #2842

@cimarronm
TST: __spec__ (an import-related variable for modules) was added in p…
69e6595 
…ython 3.4. Need to exclude in test_override_builtins.
@tacaswell tacaswell modified the milestone: v1.4.0 Apr 15, 2014
@WeatherGod
Copy link
Member

Just as a sanity question... is it indeed "ok" that we override __spec__? And what is our __spec__ in the first place? I am completely unaware of it.

@cimarronm
Copy link
Contributor Author

__spec__ is not being set by matplotlib itself but rather by the import functionality of python. It is a variable which is set by python similar to __main__ and was just added to the language in version 3.4.

The ok_to_override list is a bit of a misnomer. It includes actually two sets of variables: 1) Those which are not being overridden by any functionality of matplotlib but are simply different from globals based upon the context (like __name__, __spec__, etc.) and 2) those which are being overridden (like any, all, etc.).

tacaswell added a commit that referenced this pull request Apr 16, 2014
@tacaswell
Merge pull request #2981 from cimarronm/test_override_builtins_spec_v…
8331ba9 
…ariable

TST: __spec__ (an import-related variable for modules) was added in pyth...
@tacaswell tacaswell merged commit 8331ba9 into matplotlib:master Apr 16, 2014
@andrewclegg andrewclegg mentioned this pull request Apr 19, 2014
Closed
@efiring efiring mentioned this pull request May 22, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cimarronm @WeatherGod @tacaswell @QuLogic