MNT: expire legend-related deprecations #29832
Merged
+24
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcomer
commented
Mar 29, 2025
lib/matplotlib/legend.py
Outdated
| "be discarded. This is deprecated since %(since)s and will " | ||
| "become an error in %(removal)s.")) | ||
| raise ValueError("When passing handles and labels, they must both be " | ||
| "passed positionally or both as keywords.") |
There was a problem hiding this comment.
Is there a better exception type than ValueError for this situation?
There was a problem hiding this comment.
There's no really good match. I'm inclined to go with TypeError as that is used in other cases, when the signature is not fulfilled.
46ffb4c to
2bb7ea8
Compare
2bb7ea8 to
c5afbfc
Compare
|
Rebased to pick up #29834 |
timhoffm
approved these changes
Mar 31, 2025
oscargus
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Expire the deprecations from #27175 and #27767
PR checklist