-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Update code to Python 3.11 #29840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code to Python 3.11 #29840
Conversation
tex strings formatting avoid using {} on purpose -- you just end up with way too many nested braces... |
Yeah, they looked quite bad. Will selectively revert those and fix some other things that "looked bad". |
I'd wait a bit with this until we're pretty sure there's no need for 3.10 support anymore. Not formally supporting it and actively breaking support are two pairs of shoes. Since the changes here have marginal benefits, I'd wait with them to close before/after the 3.11 release. |
Some of the changes here are not related to dropping 3.11 so could be pulled in right now (maybe run |
I've identified like four things here:
Hence, it is only the last one that actually can go in (and maybe a few well selected formats). Closing this for now and may reopen another one. |
yield from was introduced in Python 3.3: https://docs.python.org/3.3/whatsnew/3.3.html#pep-380-syntax-for-delegating-to-a-subgenerator |
PR summary
Depends on #29796
I just went the
pyupgrade
-route so not really sure which are actually related to dropping 3.10 and what is just old code that hangs around (like the%
-formatting), but maybe just as good to get those things in as well?PR checklist