Skip to content

DOC: Improve description of background/bbox handling for Text #29875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

DOC: Improve description of background/bbox handling for Text #29875

merged 1 commit into from
Apr 7, 2025
+16 −4

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Apr 6, 2025

Inspired by #29874.

@timhoffm timhoffm mentioned this pull request Apr 6, 2025
Open
oscargus
oscargus reviewed Apr 6, 2025
View reviewed changes
lib/matplotlib/text.py

Parameters
----------
rectprops : dict with properties for `.patches.FancyBboxPatch`
rectprops : dict with properties for `.FancyBboxPatch` or None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe one should update the typing as well? If not, feel free to self merge.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@timhoffm timhoffm force-pushed the doc-text-bbox branch 2 times, most recently from a2e8941 to cf3b329 Compare April 6, 2025 22:00
@timhoffm timhoffm added this to the v3.10.2 milestone Apr 7, 2025
@timhoffm timhoffm merged commit cb9fcd6 into matplotlib:main Apr 7, 2025
41 checks passed
@timhoffm timhoffm deleted the doc-text-bbox branch April 7, 2025 00:13
@lumberbot-app Lumberbot (App)
Copy link

lumberbot-app bot commented Apr 7, 2025

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.10.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 cb9fcd69afd61983cf2bedabba2ca257ab464298
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #29875: DOC: Improve description of background/bbox handling for Text'
  1. Push to a named branch:
git push YOURFORK v3.10.x:auto-backport-of-pr-29875-on-v3.10.x
  1. Create a PR against branch v3.10.x, I would have named this PR:

"Backport PR #29875 on branch v3.10.x (DOC: Improve description of background/bbox handling for Text)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@timhoffm timhoffm modified the milestones: v3.10.2, v3.11.0 Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscargus oscargus oscargus approved these changes

Assignees
No one assigned
Labels
topic: text
Projects
None yet
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@timhoffm @oscargus