Change .T to .transpose() in _reshape_2D
#29896
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
approved these changes
Apr 10, 2025
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Apr 10, 2025
timhoffm
added a commit
that referenced
this pull request
Apr 10, 2025
…896-on-v3.10.x Backport PR #29896 on branch v3.10.x (Change `.T` to `.transpose()` in `_reshape_2D`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR introduces a small change to
lib/matplotlib/cbook.py. To make.TArray API compatible it must raise an exception for scalar arrays and arrays withndim != 2.In numpy/numpy#28678 we first introduce a warning for that purpose.
matplotlib that is used in NumPy docs-check CI job causes a failure by raising multiple warnings from
plt.hist. This backward-compatible change fixes it..transpose()stays the same as it isn't covered in Array API.