Ensure text metric calculation always uses the text cache #29907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These locations outside of `Text` were calling `Renderer.get_text_width_height_descent` directly which meant that 1. they were not cached, and 2. the `text_placeholders` fixture did not catch their use. Fortunately, this only affected one test figure.
|
Unfortunately, I missed this in #29872 because I had only tested with changing the hinting settings originally, and not with FreeType 2.13.3+mpl20 style+hinting, and only the latter changed the height significantly enough to be noticed. |
1 task
oscargus
approved these changes
Apr 12, 2025
tacaswell
approved these changes
Apr 13, 2025
|
The azure failure is 3.10 timing out in a subprocess test. |
|
@meeseeksdev backport to v3.10.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 6, 2025
…ses the text cache
oscargus
added a commit
that referenced
this pull request
May 6, 2025
…907-on-v3.10.x Backport PR #29907 on branch v3.10.x (Ensure text metric calculation always uses the text cache)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These locations outside of
Textwere callingRenderer.get_text_width_height_descentdirectly which meant thattext_placeholdersfixture did not catch their use.Fortunately, this only affected one test figure.
PR summary
PR checklist