Update pinned oldest win image on azure #29992
Conversation
The windows-2019 image will be deprecated on 1.6.2025. Also, this is a test whether the timeouts matplotlib#29797 are related to the windows-2019 image.
|
First run did not exhibit timeout. Force push to rerun CI. Let's check whether this is reliable by running CI multiple times. |
|
Second run did not exhibit timeout. Force push to rerun CI. |
|
This did not have timeouts three times in a row. I suggest to merge this and see whether our timouts are gone. We would have to update the image in a month anyway due to the deprecation, and I don't think it's a relevant miss if we don't run the windows-2019 image. |
|
There is an if-loop at line 123 that the comment states is for windows-2019. I guess that can be removed. |
The windows-2019 image will be deprecated on 1.6.2025. Also, this is a test whether the timeouts matplotlib#29797 are related to the windows-2019 image.
| @@ -100,25 +100,6 @@ stages: | |||
| echo "Coverage session ID: ${SESSION_ID}" | |||
| VS=$(ls -d /c/Program\ Files*/Microsoft\ Visual\ Studio/*/Enterprise) | |||
| echo "Visual Studio: ${VS}" | |||
| DIR="$VS/Common7/IDE/Extensions/Microsoft/CodeCoverage.Console" | |||
| if [[ -d $DIR ]]; then | |||
| # This is for MSVC 2022 (on windows-latest). | |||
There was a problem hiding this comment.
This seems to be the opposite of what you wanted to do, this comment indicates this is for 2022, not 2019. (And the tests failed without actually running, so that tracks)
The windows-2019 image will be deprecated on 1.6.2025 (#29797 (comment)). Also, this is a test whether the timeouts #29797 are related to the windows-2019 image.