Include close matches in error message when key not found #30001
+55
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
May 3, 2025
| @@ -139,6 +140,35 @@ def check_in_list(values, /, *, _print_supported_values=True, **kwargs): | |||
| raise ValueError(msg) | |||
|
|
|||
|
|
|||
| def check_in_keys(value, mappable, *, | |||
There was a problem hiding this comment.
This is basically a dupe of check_getitem, except with an additional error message?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to resurrect #28115, but make it more general so we can emit helpful error messages when keys aren't found.