-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Enable linting of .pyi files #30006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable linting of .pyi files #30006
Conversation
@ksunden did not wrap |
Worth it to me. One time effort that is annoying, but still... |
For the record, the reason I did not wrap at 88 is because the official python style guide for typing specifies 130 characters. https://typing.python.org/en/latest/guides/writing_stubs.html#maximum-line-length I don't have too strong of an opinion, but went with the standard for the filetype. |
Interesting. Seems like it is not possible to configure different line lengths for pyi and py files (if I read the documentation correctly). This seems like a good motivation to support that though. |
You could only make a separate run with different settings for pyi. |
Ah, I didn't know this! In that case I've added a exclusion for rule E501 (line length) for .pyi files, but left the rest enabled. |
Enables linting of .pyi files. Most of the fixes here are line length, other fixes are:
__all__
in__init__.pyi