Skip to content

Remove deprecated get_tick_iterator() #30014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented May 5, 2025

PR summary

Deprecated in 3.9, so time to remove in 3.11.

PR checklist

@dstansby dstansby added this to the v3.11.0 milestone May 5, 2025
@dstansby dstansby marked this pull request as draft May 5, 2025 17:12
@QuLogic
Copy link
Member

QuLogic commented May 5, 2025

What is keeping this draft (other than the name of the release snippet)?

@dstansby dstansby marked this pull request as ready for review May 6, 2025 08:45
@dstansby
Copy link
Member Author

dstansby commented May 6, 2025

Just the release snippet, updated now.

@dstansby dstansby force-pushed the rm-tick-iterator branch from f35e638 to 96ac88f Compare May 6, 2025 08:45
@oscargus
Copy link
Member

oscargus commented May 6, 2025

Anyone can merge once AppVeyor passes (or before that if you are feeling wild).

@timhoffm
Copy link
Member

timhoffm commented May 6, 2025

Appveyor failed with some obscure "can't find remote branch" message. I've restarted the run.

@QuLogic
Copy link
Member

QuLogic commented May 6, 2025

It seems to think this is a branch on this repo and not a fork. However, there's a second build for the PR that passed, so the broken one doesn't matter.

@QuLogic QuLogic merged commit 35976c9 into matplotlib:main May 6, 2025
51 of 52 checks passed
QuLogic added a commit to QuLogic/matplotlib that referenced this pull request May 7, 2025
The combination of matplotlib#30014 and matplotlib#30015 made this import redundant, but as
each PR was indepenently tested and reviewed, nothing was evident until
both were merged.
@QuLogic QuLogic mentioned this pull request May 7, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants