Micro-optimize _to_rgba_no_colorcycle. #30020
Merged
+20
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
May 6, 2025
f3f2c44 to
9dc9749
Compare
QuLogic
reviewed
May 7, 2025
lib/matplotlib/colors.py
Outdated
| return (*[n / 0xff for n in bytes.fromhex(c[1:])], | ||
| alpha if alpha is not None else 1.) | ||
| elif len(c) == 4: # #rgb hex format, shorthand for #rrggbb. | ||
| return (*[int(n, 16) * 0x11 / 0xff for n in c[1:]], |
There was a problem hiding this comment.
This is just ?
Suggested change
| return (*[int(n, 16) * 0x11 / 0xff for n in c[1:]], | |
| return (*[int(n, 16) / 0xf for n in c[1:]], |
There was a problem hiding this comment.
ah indeed, even better.
timhoffm
approved these changes
May 7, 2025
This patch speeds up conversions of `#rgba`-type formats by between 25% and 40% (while shortening the implementation), although real benefits should be limited because of caching in to_rgba.
|
@story645 Did you mean to close this? |
No sorry, my phone's been a little broken and I was probably looking at this on the app and accidentally closed it w/o noticing |
QuLogic
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch speeds up conversions of
#rgba-type formats by between 25% and 40% (while shortening the implementation), although real benefits should be limited because of caching in to_rgba.PR summary
PR checklist