Feature Implementation for "setting spine default location displacement rcParams" *ATTEMPT 2* - DRAFT PR #30024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note for the future: You do not have to close PRs and open a new one "ATTEMPT 2". Instead, just force-push changes to the existing branch. That will automatically update the existing PR. |
|
Is this PR an appropriate implementation of this feature? Do I need to add to the documentation, or write a test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** DRAFT PULL REQUEST **
closes #13930
This PR is a re-attempt of PR #30011 which I think I messed up. I address the comments made in that PR conversation as well.
Implementing feature to set default spine positions for top, left, right and bottom using rcParams. Feature implementation involves the addition of four new rcParams:
axes.spines.left.position
axes.spines.right.position
axes.spines.bottom.position
axes.spines.top.position
The default value for the rcParams is ('outward', 0.0). The 'axes.spines.{spine_type}.position' format for the rcParams was chosen, as 'axes.spines.{spine_type}' is already taken for another purpose, I believe whether to show or not show an axis.
The rcParams can be set to ('outward' | 'axes' | 'data', amount) or 'center' or 'zero'
Below is a screenshot showing the feature in action.