Move test data into a single subdirectory #30061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
approved these changes
May 17, 2025
| @@ -33,15 +33,15 @@ def build_sphinx_html(source_dir, doctree_dir, html_dir, extra_args=None): | |||
|
|
|||
|
|
|||
| def test_tinypages(tmp_path): | |||
| shutil.copytree(Path(__file__).parent / 'tinypages', tmp_path, | |||
| shutil.copytree(Path(__file__).parent / 'data/tinypages', tmp_path, | |||
There was a problem hiding this comment.
While all these lines are being changed, it might be worth adding "tinypages_data_path = Path(file).parent / "data" / "tinypages"` variable to the file and re-using it?
Consolidating these files make it easier to remove or restore them without having to track each one individually.
timhoffm
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Consolidating these files make it easier to remove or restore them without having to track each one individually.
The main reason for this is #29093, wherein we can restore the test data (to the temporary testing environment) more easily if it's a single subdirectory.
PR checklist