Skip to content

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 23, 2025

... to fix unicode glyph sizing issues for svg & patheffects.

This is the patch at #29791 (comment) with a test. Closes #12928 (comment). Closes #27654. Closes #28675. Closes #29791. Supersedes #14159.

PR summary

PR checklist

@QuLogic
Copy link
Member

QuLogic commented May 24, 2025

This is the patch at #29791 (comment) with a test. Closes #12928, #27654, #28675, #29791. Supersedes #14159.

You need the Closes magic for every issue you want to close, commas don't work there.

@anntzer
Copy link
Contributor Author

anntzer commented May 24, 2025

thanks, edited.

... to fix unicode glyph sizing issues for svg & patheffects.
@@ -443,7 +443,8 @@ will often automatically include these collections.
| | `lm <https://ctan.org/pkg/lm>`_, |
| | `txfonts <https://ctan.org/pkg/txfonts>`_ |
+-----------------------------+--------------------------------------------------+
| collection-latex | `geometry <https://ctan.org/pkg/geometry>`_, |
| collection-latex | `fix-cm <https://ctan.org/pkg/fix-cm>`_, |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we drop L455 (the type1cm) below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, see (the links at the bottom of) #29791 (comment) for why we still need type1cm being installed (even if not usepackage'd).

@tacaswell tacaswell added this to the v3.11.0 milestone May 27, 2025
@QuLogic
Copy link
Member

QuLogic commented May 27, 2025

Closes #12928.

Is this reference right? It's an already-merged PR.

@anntzer
Copy link
Contributor Author

anntzer commented May 28, 2025

Sorry, that was not a real issue. It's rather than #12928 partially fixed #8068 by allowing loading of unicode glyphs in svg usetex, but loaded some of them at the wrong size, as noted at the bottom of #12928 (comment). Edited the link above for clarity.

@QuLogic QuLogic merged commit 4f26d9a into matplotlib:main May 28, 2025
40 checks passed
@QuLogic QuLogic mentioned this pull request May 28, 2025
6 tasks
@anntzer anntzer deleted the fcm branch May 28, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants