FIX: Ensure Locators on RadialAxis are always correctly wrapped #30174
+52
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the wrapping logic is now contained in RadialAxis Closes matplotlib#30164 and rearchitects matplotlib#29798.
anntzer
reviewed
Jun 15, 2025
| RadialLocator(self.get_major_locator(), self.axes)) | ||
| self.isDefault_majloc = is_default | ||
|
|
||
| def set_major_locator(self, locator): |
There was a problem hiding this comment.
I guess you could inline the logic of _wrap_locator_formatter here (if not isinstance(locator, RadialLocator): locator = RadialLocator(locator, self.axes)) which would save you from having to mess with isdefault_majloc?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the wrapping logic is now done whenever a new locator is set in RadialAxis.
Closes #30164 and rearchitects #29798.