Skip to content

Fix figure legend when drawing stackplots #30186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025

Conversation

dstansby
Copy link
Member

PR summary

Fixes #30158 - as suggested in #30158 (comment), two calls were trying to set the figure, and I think one of them doesn't need to.

PR checklist

@QuLogic
Copy link
Member

QuLogic commented Jun 19, 2025

Yes, I believe this is correct; HandlerBase.update_prop will set the correct figure (via Legend._set_artist_props), HandlerPolyCollection._update_prop exists to do the class-specific work of pulling the properties from the first artist in a collection and doesn't need to set the figure.

This could do with a test though.

@rcomer
Copy link
Member

rcomer commented Jun 28, 2025

Seems right to me too. The legend and the artists it contains (e.g. legend_handle here) are on the root Figure, whereas orig_handle is on the SubFigure, so they should not match.

@dstansby dstansby force-pushed the fig-legend-error branch from e1a820c to b370e30 Compare July 6, 2025 20:51
@dstansby dstansby marked this pull request as ready for review July 6, 2025 20:51
@timhoffm timhoffm merged commit 99b4ee3 into matplotlib:main Jul 7, 2025
41 checks passed
@tacaswell tacaswell added this to the v3.10.4 milestone Jul 7, 2025
@tacaswell
Copy link
Member

@meeseeksmachine please backport to 3.10.x

@rcomer
Copy link
Member

rcomer commented Jul 7, 2025

@meeseeksdev backport to v3.10.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jul 7, 2025
QuLogic added a commit that referenced this pull request Jul 7, 2025
…186-on-v3.10.x

Backport PR #30186 on branch v3.10.x (Fix figure legend when drawing stackplots)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Stackplot in SubFigure raises when drawing Legend
5 participants