Skip to content

Fixed incomplete deletion of all images that have passed tests before upload #30188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025
Merged

Fixed incomplete deletion of all images that have passed tests before upload #30188

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b154237
Clean up image files that may be symbolic links to files
ayshih Jun 19, 2025
8c75238
Clean up GIF image files from passing tests
ayshih Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,13 +346,15 @@ jobs:
run: |
function remove_files() {
local extension=$1
find ./result_images -type f -name "*-expected*.$extension" | while read file; do
find ./result_images -name "*-expected*.$extension" | while read file; do
if [[ $file == *"-expected_pdf"* ]]; then
base=${file%-expected_pdf.$extension}_pdf
elif [[ $file == *"-expected_eps"* ]]; then
base=${file%-expected_eps.$extension}_eps
elif [[ $file == *"-expected_svg"* ]]; then
base=${file%-expected_svg.$extension}_svg
elif [[ $file == *"-expected_gif"* ]]; then
base=${file%-expected_gif.$extension}_gif
else
base=${file%-expected.$extension}
fi
Expand All @@ -369,7 +371,7 @@ jobs:
done
}

remove_files "png"; remove_files "svg"; remove_files "pdf"; remove_files "eps";
remove_files "png"; remove_files "svg"; remove_files "pdf"; remove_files "eps"; remove_files "gif";

if [ "$(find ./result_images -mindepth 1 -type d)" ]; then
find ./result_images/* -type d -empty -delete
Expand Down
Loading