Skip to content

Create events type and update plt.connect and mpl_connect #30275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 10, 2025
Merged

Create events type and update plt.connect and mpl_connect #30275

merged 3 commits into from
Jul 10, 2025
+87 −18

Conversation

ZPyrolink
Copy link
Contributor

PR summary

This PR update the mpl_connect function and his corresponding pyplot wrapper.

  • Create literals for each event:
    • MouseEventType
    • KeyEventType
    • DrawEventType
    • PickEventType
    • ResizeEventType
    • CloseEventType
  • Create literal for all events: EventType
  • Update mpl_connect and plt.connect with these new types
  • Create mpl_connect overload for DrawEvent

PR checklist

timhoffm
timhoffm approved these changes Jul 8, 2025
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

QuLogic
QuLogic reviewed Jul 8, 2025
View reviewed changes
@QuLogic QuLogic added this to the v3.11.0 milestone Jul 10, 2025
@QuLogic QuLogic merged commit 4284a0b into matplotlib:main Jul 10, 2025
40 checks passed
This was referenced Jul 12, 2025
Closed
Open
@ZPyrolink ZPyrolink mentioned this pull request Jul 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: canvas and figure manager topic: pyplot API topic: typing
Projects
None yet
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ZPyrolink @QuLogic @timhoffm