-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Move release related docs to new sub-folder #30304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Probably this will need a 501 redirect on the server? |
Does the spinx redirect directive not handle the redirects by itself? I can't work out why the doc build is failing. It says
but, as far as I can see there's only one redirect from users/release_notes_next 🤔 |
I think there's one more level handled in https://github.com/matplotlib/matplotlib.org |
Sorry, I'm not following - what does "one more level handled" mean? |
Since the improvements/fixes to the redirection code are orthogonal to moving these docs around, I put them in #30309 |
Ok i had not noticed that you'd put a redirect-from in each file. Seems fine if it works! I was suggesting just redirecting the subdirectory at the server config, but if this caught everything it should be ok |
Just that I remember having to ask @QuLogic to do some redirects on the matplotlib.org repo for the other PRs on that issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably should update mpl-sphinx-theme to point to the new URLs before the next release, to avoid extra redirects.
@@ -110,10 +110,10 @@ | |||
- all: | |||
- changed-files: | |||
- any-glob-to-any-file: | |||
- 'doc/users/**' | |||
- 'doc/release/**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incorrect; we don't want the user guide label to apply to release docs.
That was stable -> devel (which means independent build directories); this is all internal to the a single build, so shouldn't need anything server side. |
PR summary
See #27396.
This moves release-related docs to their own folder within the docs (/release).
PR checklist