Skip to content

Improve custom sphinx link redirect extension #30309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2025
Merged

Improve custom sphinx link redirect extension #30309

merged 2 commits into from
Jul 14, 2025
+7 −2

Conversation

dstansby
Copy link
Member

PR summary

  • Only raise an error if trying to redirect one page to a different page to the one it's alraedy redirected to
  • When raising the error, print the page that's trying to insert the conflicting redirect. This helps debugging where the error is coming from.

PR checklist

@github-actions github-actions bot added the Documentation: build building the docs label Jul 14, 2025
@dstansby dstansby mentioned this pull request Jul 14, 2025
Draft
5 tasks
@QuLogic QuLogic added this to the v3.11.0 milestone Jul 14, 2025
@jklymak jklymak merged commit 63756df into matplotlib:main Jul 14, 2025
21 checks passed
@dstansby dstansby deleted the improve-redirecter branch July 15, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
Documentation: build building the docs
Projects
None yet
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dstansby @QuLogic @jklymak