TST: Remove qt_core fixture #30398
TST: Remove qt_core fixture #30398
Conversation
It doesn't seem very useful now, since we import `QtGui` at the top level anyway.
|
Should we be going the otherway and removing the top level imports? |
|
The toplevel ones set a marker to skip all tests in the file if the import isn't available. This fixture actually appears to do nothing, other than maybe deferring the import a little later. It made more sense for Qt4 vs Qt5, I think? |
There was a problem hiding this comment.
IMO the mark-on-import-error approach is cleaner than the fixture approach.
It's a little less flexible (you can't selectively skip tests), but overall if Qt is not importable likely no backend_qt tests are reasonably able to run - or a bit stronger: If Qt is not importable, we should not bother with any Qt-related tests even if that test could technically run without Qt.
|
I'll merge as I agree that the current fixture is doing nothing for us, but I am still not sure we want to have any GUI frameworks at the top level of any of the tests. As importing is process-global thing and trying to use multiple frameworks in the same process at different times leads to weird crashes (we have a test which is "do we warn if you import multiple versions of qt bindings because it might segfault"), I think is a version of leaving Chekhov's gun on the mantel in case we do this in some other frameworks tests. |
PR summary
It doesn't seem very useful now, since we import
QtGuiat the top level anyway.PR checklist