fix(font manager): Allow Rebuilding Cache #30406
Open
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One could never rebuild the cache given the existing conditional logic (premature return to exception based solely on fallback_to_default). Now, if a user disables fallback and enables rebuild, the rebuild logic will execute.
This allows a user to install a font and run:
to force a rebuild of the font cache.
It was a simple fix to the conditional logic: if fallback is False, don't return with error if rebuild is True, but instead set result to empty string (used later in the rebuild code) so that the rebuild code can actually be proceeded to.
PR summary
PR checklist
Tested on my font cache locally in my normal non-dev env.
Unless other ideas exist, a unit test would require: