Improve cursor icons with RectangleSelector #30499
Open
+51
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Aug 31, 2025
6ee977c to
4d2e657
Compare
timhoffm
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This adds appropriate cursor icons for
RectangleSelectorwhen 1) creating a new selector and 2) moving an existing selector. This is part of #20724. I've held off on implementing more cursor improvements to the widgets because this PR also factors out some logic to enable that.If the approach looks good on first review I could update this PR to add cursors across the widgets where appropriate, or do that in a follow up PR.
PR checklist