Prepare for MetaFont/PK font support. #30514
Open
+84
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3fee17f to
76d704f
Compare
QuLogic
reviewed
Sep 6, 2025
lib/matplotlib/dviread.py
Outdated
| # PK fonts have no encoding information; report glyphs as ASCII but | ||
| # with a "?" to indicate that this is just a guess. | ||
| return (f"{chr(self.glyph)}?" if chr(self.glyph).isprintable() else | ||
| "??") |
There was a problem hiding this comment.
Should we fall back to something like f'pk{self.glyph:x}' so that they are all unique? (the pk prefix is something like the uni prefix on Unicode-encoded glyphs)
There was a problem hiding this comment.
Sure, went for a variant.
lib/matplotlib/dviread.py
Outdated
Comment on lines
768
to
771
| try: | ||
| psfont = PsfontsMap(find_tex_file("pdftex.map"))[self.texname] | ||
| except LookupError as exc: |
There was a problem hiding this comment.
I assume it would never had generated a LookupError anyway, but the PsfontsMap constructor seems like a lot to put in this try.
There was a problem hiding this comment.
Sure, took it out. (Also removed an unrelated and now unused PsfontsMap call.)
TeX MetaFont (.mf) fonts (e.g., from `\usepackage{concmath}`) need to be
converted to raster (.pk) fonts before usage. In dvipng or pdftex this
is done by invoking mktexpk via kpsewhich.
This patch ensures that our calls to kpsewhich likewise also generate
and finds the raster files (in Matplotlib's own temporary cache) when
needed. The resolution (600dpi) is the documented default (see e.g. the
-D option in `man kpsewhich`). Note that this is only a preliminary
step towards full MF/PK font support, which would also require parsing
the PK file and embedding the glyphs into our final output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TeX MetaFont (.mf) fonts (e.g., from
\usepackage{concmath}) need to be converted to raster (.pk) fonts before usage. In dvipng or pdftex this is done by invoking mktexpk via kpsewhich.This patch ensures that our calls to kpsewhich likewise also generate and finds the raster files (in Matplotlib's own temporary cache) when needed. The resolution (600dpi) is the documented default (see e.g. the -D option in
man kpsewhich). Note that this is only a preliminary step towards full MF/PK font support, which would also require parsing the PK file (which I have implemented elsewhere) and embedding the glyphs into our final output (for which I have a preliminary version in mplcairo).Work towards fixing #20469.
PR summary
PR checklist