Implement arrow3d method in Axes3D
#30517
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34397ac to
893c34e
Compare
story645
reviewed
Sep 5, 2025
lib/mpl_toolkits/mplot3d/art3d.py
Outdated
| """ | ||
| 3D FancyArrowPatch object. | ||
| """ | ||
| def __init__(self, xs, ys, zs, *args, **kwargs): |
There was a problem hiding this comment.
Suggested change
| def __init__(self, xs, ys, zs, *args, **kwargs): | |
| def __init__(self, posA, posB, *args, **kwargs): |
I think the signature should match the FancyArrowPatch signature unless you have a reason not to. I implemented a rudimentary version with this signature:
https://github.com/story645/team/blob/00c7374cefb216e51b8f8350a4b5512ec1068a99/paper/figcode/nontrivial.py#L54-L64
|
IMO the major challenge here is semantics, scope and API design and that will entail the same topics as #29826 (comment), which lead to stalling in that thread. After all, we should have a consistent story between 2d and 3d. - I suspect to move forward here, we have to pick up the discussion from #29826. |
893c34e to
ba9dcd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
closes #22571
This PR implements a method to plot a 3D arrow.
The
ax.arrow3dmethod plots a single arrow between specified end, start points. It returns an instance of theArrow3Dclass, which inherits from theFancyArrowPatchclass. Additional kwargs are passed on toFancyArrowPatchto change properties of the arrow.PR checklist