Bug restore boxplot defaults #3165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doplot for horizontal boxes (internal bxp helper function) assumes that it will be passed an even number of positional arguments which it swaps pair-wise. The code to draw the fliers also passes in a format string which breaks the assumption. - re-worked how `bxp` deals with the `sym` input - minor pep8
|
@phobson Can you take a look at this and make sure I didn't muck the defaults up (again). |
|
Yeah. Btw, the extra props were because the box and whiskers each had different linestyles in the original defaults. -- On Sat, Jun 28, 2014 at 11:31 AM, Thomas A Caswell
|
If the user passes is the string 'ro' assume they want filled circles. This is also the old behavior.
| If provided, will set the plotting style of the whiskers | ||
|
|
||
| capprops : dict or None (default) | ||
| If provided, will set the plotting style of the whiskers |
There was a problem hiding this comment.
I think you mean "caps" here, not "whiskers".
|
And don't merge this yet, there is still an issue with where the management of the x-ticks |
changed labeling in cbook.box_plotstats to start at 1 to maintain back compatibility
|
I think this should be good-to-go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-base + bug fixes
supersedes #3066 closes #3042