Fix deprecation warning in simple_linear_interpolation #3198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build error doesn't seem to be related to this fix. |
|
3.2 is broken at the moment. This is the right course of action in terms of PRs. |
| @@ -1746,8 +1746,7 @@ def simple_linear_interpolation(a, steps): | |||
| result[0] = a[0] | |||
| a0 = a[0:-1] | |||
| a1 = a[1:] | |||
| delta = ((a1 - a0) / steps) | |||
| steps = int(steps) | |||
| delta = (a1 - a0) / float(steps) | |||
There was a problem hiding this comment.
should not need the float as we have from __future__ import divsion
|
My bad, I hadn't noticed! |
|
This is also a part of #3241 Which should fix all of these warnings |
|
Closing in favor of #3241 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On master, when drawing polar plots:
Ps: could I have pushed this on #2100 instead of creating another PR ?