Fix lots of warnings in docs/Examples that crash #3224
Conversation
Fix some examples that crash.
| * In `~matplotlib.finance`, almost all functions have been deprecated | ||
| and replaced with a pair of functions name `*_ochl` and `*_ohlc`. | ||
| The former is 'open-close-high-low' order of quotes, and what the | ||
| module used and the later is 'open-high-low-close' order of quotes, |
There was a problem hiding this comment.
"The former is the 'open-close-high-low' order of quotes used previously in this module, and the latter is the 'open-high-low-close' order that is standard in finance."
That alternative version of the sentence fixes several little errors.
There was a problem hiding this comment.
Sure. I was really just limiting myself to formatting changes, but we might as well fix this while we're at it.
|
I am a bit worried that this is going to clash in a very bad way with #3170.... |
|
Although, this merges cleanly into that one. We apparently fixed different brokenness in the docs. |
|
That looks good. My policy when it comes to conflicting PR is the first one in wins, and the other one deals with conflicts, but I'll let someone push the green button (which is grey thanks to travis failing). |
|
Sure -- we can merge/address conflicts in whatever makes sense for everyone else. |
Fix lots of warnings in docs/Examples that crash
Fix some examples that crash.
Doesn't get all the warnings, but a significant fraction. (Let's automate the doc build! 👍)