Skip to content

WIP: Add greyscale and color-blindness filters. #3279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented Jul 18, 2014

Any artist can now do:

x.set_agg_filter(...)

to set a greyscale or color-blindness filter. This is the first step toward a more automated previewing for colorblind accessibility of plots.

Only works with Agg backend, of course -- this just builds on top of the work @leejjoon did.

@kthyng: I'd love your feedback on this, as it was really inspired by your Scipy presentation.

@rhattersley
Copy link
Contributor

Nice one @mdboom. 👍 I'd suggested the idea of a preview to @kthyng but she mentioned you were halfway done already. 😄

This is the first step toward a more automated previewing

Are you planning on taking the next steps as well?

@tacaswell tacaswell added this to the v1.5.x milestone Jul 23, 2014
@mdboom
Copy link
Member Author

mdboom commented Jul 25, 2014

@rhattersley wrote:

Are you planning on taking the next steps as well?

I'd like to, but can't promise the time to right now. I think this PR could be merged with the addition of tests and changelog stuff without the interactive part. That would free it up for myself or any other brave volunteer to implement that later. (It will be a lot easier to do that once the new toolbar infrastructure is in place, as well).

@kthyng
Copy link
Contributor

kthyng commented Jul 30, 2014

@mdboom Ok I finally got around to trying all this out. What sort of
argument goes into x.set_agg_filter()?

On Fri, Jul 25, 2014 at 3:21 PM, Michael Droettboom <
notifications@github.com> wrote:

@rhattersley https://github.com/rhattersley wrote:

Are you planning on taking the next steps as well?

I'd like to, but can't promise the time to right now. I think this PR
could be merged with the addition of tests and changelog stuff without the
interactive part. That would free it up for myself or any other brave
volunteer to implement that later. (It will be a lot easier to do that once
the new toolbar infrastructure is in place, as well).


Reply to this email directly or view it on GitHub
#3279 (comment)
.

Kristen M. Thyng
Postdoctoral Research Associate
Department of Oceanography
Texas A&M University
http://kristenthyng.com

@mdboom
Copy link
Member Author

mdboom commented Jul 31, 2014

Any of these string values should work:

mapping = {
 +        'luminosity': luminosity_filter,
 +        'average': average_filter,
 +        'deuteranope': deuteranope_filter,
 +        'protanope': protanope_filter,
 +        'tritanope': tritanope_filter
 +    }

(and the docstring will get updated to that effect before this gets merged).

@tacaswell tacaswell modified the milestones: proposed next point release, next point release Feb 19, 2015
@tacaswell
Copy link
Member

@mdboom state of this?

@tacaswell
Copy link
Member

ping @mdboom

@tacaswell tacaswell modified the milestones: next point release, proposed next point release Jul 17, 2015
@tacaswell tacaswell modified the milestones: 2.1 (next point release), 2.2 (next next feature release) Aug 29, 2017
@jklymak
Copy link
Member

jklymak commented May 24, 2018

Is this a feature we still want? Someone should re-open if they want to take this up, but closing as abandoned, plus I'm skeptical about the API....

@jklymak jklymak closed this May 24, 2018
QuLogic added a commit to QuLogic/matplotlib that referenced this pull request Jul 14, 2021
This is based on matplotlib#3279 in essence, but rewritten to use colorspacious
and modernized somewhat.
QuLogic added a commit to QuLogic/matplotlib that referenced this pull request Jul 15, 2021
This is based on matplotlib#3279 in essence, but rewritten to use colorspacious
and modernized somewhat.
@story645 story645 removed this from the future releases milestone Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants