Skip to content

Float division patches #3289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Float division patches #3289

wants to merge 2 commits into from

Conversation

argriffing
Copy link

Use integer division where numpy gives DeprecationWarning.

@tacaswell
Copy link
Member

Can you make sure that this does not clash with the other PRs running to clean up warnings?

@argriffing
Copy link
Author

Can you make sure that this does not clash with the other PRs running to clean up warnings?

Sorry I have no idea how to do that, I didn't even run the unit tests properly before submitting this PR...

Edit: Oh I see what you mean, I just looked through the open PR list and found #3241 which is similar to this PR but a bit less careful in some places. For example that PR nukes the nans which are used in one of those functions. Also #3271.

@argriffing argriffing mentioned this pull request Jul 23, 2014
Merged
@tacaswell tacaswell added this to the v1.4.x milestone Aug 18, 2014
@tacaswell
Copy link
Member

@jenshnielsen Can you take a look at this?

@jenshnielsen
Copy link
Member

I am going to close this since #3241 incorporates the same fixes and some additional ones. You are right about the issue in contour which has been fixed in that pull request. Sorry for the duplicate effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.x
Development

Successfully merging this pull request may close these issues.
4 participants
@argriffing @tacaswell @jenshnielsen @alexbrc