Added center and frame arguments for pie-charts [merge to master at cl] #3433
Conversation
|
This looks good to me. Could you add a test the produces one or more pie charts which uses the frame and a non zero center? Others may have different opinions but I think this is a new feature so it should go on the master branch not the 1.4.x branch, but since the changes are rather uninvolved I might be convinced otherwise. |
|
I am also in favor of this targeting the master branch. I am hoping to keep 1.4.x bug fixes only and do more frequent point releases. Don't worry about re-targetting it, we can just do the merge by into master when it is ready. |
|
Added tests for three non zero centered pie charts with axis frame on. (And On 29 August 2014 18:33, Thomas A Caswell notifications@github.com wrote:
Kimmo Palin |
| if not frame: | ||
| self.set_frame_on(False) | ||
| self.set_xlim((-1.25, 1.25)) | ||
| self.set_ylim((-1.25, 1.25)) |
There was a problem hiding this comment.
Won't this interact badly with the center kwarg?
|
Merged to master in e7717f7 |
DOC/PEP8 : details related to PR #3433
Added new functionality to ax.pie() method for placing the pie chart on given location and letting the axis frame remain with the chart. This is the same change as in pull request #2931 but moved to v1.4.x branch