Skip to content

Rcparam validation fix #3564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Oct 14, 2014
Merged

Rcparam validation fix #3564

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
5c9ccf0
MNT : make sure to cast to unicode
tacaswell Sep 25, 2014
ec7276c
BUG : make rcParams.update validates inputs
tacaswell Sep 25, 2014
a298ab2
MNT : simplify and relax validation on nseq
tacaswell Sep 25, 2014
8602912
BUG : validate_stringlist should drop empty strings
tacaswell Oct 1, 2014
31fe5e0
BUG : give animation args valid default values
tacaswell Oct 1, 2014
30eaa0b
TST : minor tweaks to animation smoketests
tacaswell Oct 1, 2014
1c2bc58
TST : added tests for some validation functions
tacaswell Oct 1, 2014
1f06313
BUG : validate input on the way into rcparams
tacaswell Oct 1, 2014
a88f5dd
TST : tests to make sure rcparams get validated
tacaswell Oct 1, 2014
0aa2fcd
TST : skip the fail tests on 2.6
tacaswell Oct 1, 2014
d9ab665
MNT : no deprecated rcparams in RcParamDefault
tacaswell Oct 1, 2014
99e3be3
TST : add cleanup decorators to some tests
tacaswell Oct 1, 2014
c93041c
MNT : re-work obsolete_rcparams
tacaswell Oct 1, 2014
962793b
TST : known fail more tests on 2.6
tacaswell Oct 1, 2014
b7e0719
TST : special case pathexists for None
tacaswell Oct 1, 2014
4cc899c
BUG : fixed string list default values
tacaswell Oct 5, 2014
f1f5795
ENH : change failed validations into warnings
tacaswell Oct 10, 2014
d8fb745
TST : known-fail rcparam exceptions tests
tacaswell Oct 10, 2014
726495e
TST : added test that keymap values are all lists
tacaswell Oct 11, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ENH : change failed validations into warnings 
Catch exceptions raised due to failed validations, force
setting the (un validated!) value, and print a warning.
  • Loading branch information
@tacaswell
tacaswell committed Oct 10, 2014
commit f1f5795ba0d6844cb50bf3d71f5bd405ac7cb6e0
28 changes: 25 additions & 3 deletions lib/matplotlib/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,7 @@ def _is_writable_dir(p):

return True


class Verbose:
"""
A class to handle reporting. Set the fileo attribute to any file
Expand Down Expand Up @@ -808,6 +809,14 @@ def matplotlib_fname():
_all_deprecated = set(chain(_deprecated_ignore_map,
_deprecated_map, _obsolete_set))

_rcparam_warn_str = ("Trying to set {key} to {value} via the {func} "
"method of RcParams which does not validate cleanly. "
"This warning will turn into an Exception in 1.5. "
"If you think {value} should validate correctly for "
"rcParams[{key}] "
"please create an issue on github."
)


class RcParams(dict):

Expand All @@ -827,7 +836,14 @@ class RcParams(dict):
# validate values on the way in
def __init__(self, *args, **kwargs):
for k, v in six.iteritems(dict(*args, **kwargs)):
self[k] = v
try:
self[k] = v
except (ValueError, RuntimeError):
# force the issue
warnings.warn(_rcparam_warn_str.format(key=repr(k),
value=repr(v),
func='__init__'))
dict.__setitem__(self, k, v)

def __setitem__(self, key, val):
try:
Expand Down Expand Up @@ -866,9 +882,15 @@ def __getitem__(self, key):
# all of the validation over-ride update to force
# through __setitem__
def update(self, *args, **kwargs):

for k, v in six.iteritems(dict(*args, **kwargs)):
self[k] = v
try:
self[k] = v
except (ValueError, RuntimeError):
# force the issue
warnings.warn(_rcparam_warn_str.format(key=repr(k),
value=repr(v),
func='update'))
dict.__setitem__(self, k, v)

def __repr__(self):
import pprint
Expand Down