Functionalizing examples/pie_and_polar_charts #3577
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks really good at a high level. Thanks for the contribution! It might be an open question whether we want the data at the top of the file (as you've done) or at the bottom before the stuff that fires off the plots. @tacaswell: opinions? These all need to be PEP8-ified (spaces after commas, etc.) The easiest way to find these is to install the |
Conflicts: examples/specialty_plots/hinton_demo.py
|
Thanks for the contribution, and sorry it never got merged; since we're moving towards tutorial-oriented examples that aren't functionalised, and this looks like a nasty rebse I'm going to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At Bloomberg Open Source Day, as Tom requested turned the example scripts into functions to make them clearer.
Sorry about docstrings, I don't really write documentation at my day job.