Skip to content

fix pep8 error classes e20[12] and e22[12] in examples #3635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 17, 2014
Merged

fix pep8 error classes e20[12] and e22[12] in examples #3635

merged 3 commits into from
Oct 17, 2014

Conversation

twmr
Copy link
Contributor

@twmr twmr commented Oct 11, 2014

E201 whitespace after ‘(‘
E202 whitespace before ‘)’

E221 multiple spaces before operator
E222 multiple spaces after operator

twmr added 2 commits October 11, 2014 17:06
@twmr
fix E221 pep8 errors
19eeb22
@twmr
fix E222 pep8 errors
ed31fee 
Signed-off-by: Thomas Hisch <t.hisch@gmail.com>
twmr
twmr reviewed Oct 11, 2014
View reviewed changes
examples/pylab_examples/table_demo.py
[58230, 381139, 78045, 99308, 160454],
[89135, 80552, 152558, 497981, 603535],
[78415, 81858, 150656, 193263, 69638],
[139361, 331509, 343164, 781380, 52269]]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are fine with that, I'll revert the white-space changes here and in the triplot examples

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on reverting this. The goal is to make it readable, not be pedantic about white space.

@tacaswell
Copy link
Member

There are 0 non-white space changes in this PR.

@twmr
fix E201 and E202 pep8 errors
ea8617d 
Signed-off-by: Thomas Hisch <t.hisch@gmail.com>
@twmr twmr force-pushed the examples_pep8_e201_202_e221_222 branch from ddaa70e to ea8617d Compare October 11, 2014 16:09
@tacaswell tacaswell modified the milestone: v1.5.x Oct 17, 2014
@twmr
Copy link
Contributor Author

twmr commented Oct 17, 2014

Any other comments?

@tacaswell
Copy link
Member

restarted travis, will merge when it passes

tacaswell added a commit that referenced this pull request Oct 17, 2014
@tacaswell
Merge pull request #3635 from thisch/examples_pep8_e201_202_e221_222
46a5603 
PEP8 : fix pep8 error classes e20[12] and e22[12] in examples
@tacaswell tacaswell merged commit 46a5603 into matplotlib:master Oct 17, 2014
@jenshnielsen jenshnielsen mentioned this pull request Oct 17, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@twmr @tacaswell