Bugfix for path collection rendering on agg backends [backport to 1.4.x] #3761
Conversation
has line segments with very large horizontal differences between vertices
|
@efiring: Would you mind having a look at this one? I think you implemented the "chunking" feature that is being removed here. |
|
@mdboom, It looks to me like this code comes from @pelson, or was last modified by him. It looks like it might be an optimization, going straight to draw_markers instead of drawing a collection when there is only one element. This seems odd, though. I hope the wizard of the rainy isles can illuminate it. |
|
"wizard of the rainy isles" @efiring, doesn't rain in Hawaii as well? :-P On Thu, Nov 20, 2014 at 2:38 PM, Eric Firing notifications@github.com
|
|
On 2014/11/20, 3:40 PM, Benjamin Root wrote:
It's not rain, it's liquid sunshine. |
|
@efiring: Sorry -- I thought I was looking at something else. I'll dig further... |
|
@cimarronm: Thanks for the investigating this so well -- it really helped to pinpoint a solution. I've created #3826 which, rather than turning the optimization off altogether, ensures that the path is small enough before performing the optimization. |
😆 - we don't get rain here - its mostly aerified ocean. And sometimes we can even stay dry. |
Attempt to fix issue with drawing collections artist which include vertices that are extremely far apart horizontally while being rendered through the agg backend. This seems to resolve issue #3626 but may not be the proper fix.