WebAgg: flush stdout after printing, redirect "stopped" message to stder... [backport to 1.4.x] #3762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try: | ||
| tornado.ioloop.IOLoop.instance().start() | ||
| except KeyboardInterrupt: | ||
| print("Server stopped") | ||
| six.print_("Server is stopped", file=sys.stderr) |
There was a problem hiding this comment.
We are using from from future import print_function at the top so I don't think there is any need for using six here
|
What is the logic for printing the interupt message to stderr? 👍 on flush 👎 on stderr, on the basis of not changing things that can break user code without good reason. |
Without flushing, the message can be displayed too late
|
The logic is that KeyboardInterrupt (as any other Exception) is written to stderr. Anyway, changed as requested. |
tacaswell
added a commit
that referenced
this pull request
Nov 12, 2014
MNT : WebAgg: flush stdout after printing, redirect "stopped" message to stder
tacaswell
added a commit
that referenced
this pull request
Nov 12, 2014
MNT : WebAgg: flush stdout after printing, redirect "stopped" message to stder
|
Thanks! Cherry-picked as 8ca8a2c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...r
Without flushing, the message can be displayed too late. KeyboardInterrupt message should be printed to stderr.