Add legend.facecolor and edgecolor to rcParams #3792
Conversation
|
For back-compatibility the should probably default to |
|
This should also get an entry in what_new along with the rest of the new rcparams. |
|
Thanks for the tips. I have commited those changes. |
| @@ -661,6 +661,9 @@ def __call__(self, s): | |||
| # the relative size of legend markers vs. original | |||
| 'legend.markerscale': [1.0, validate_float], | |||
| 'legend.shadow': [False, validate_bool], | |||
| 'legend.facecolor': ['w', validate_color], # background color; white | |||
There was a problem hiding this comment.
These are the actual default values.
There was a problem hiding this comment.
I have a PR open against your master branch to fix this + add a test, please review of merge.
|
OK, I think, it's ready. |
|
Can you revert your last commit? The new rcparams need should be set to None in the template. |
This reverts commit 2896080.
Sure, don't ask me what I was thinking... ;) Thank you! Marek |
ENH : added legend.edgecolor and legend.facecolor rcparams Merged locally to discard a commit + it's reversion.
|
Closing as I merged most of these commits (dropping the last two) by hand as 92e608d |
Attempt to implement 'inherited' rcparams, that is rcparams that are only used if they are non-default. Re-introduces feature introduced in matplotlib#3792 /92e608d655f1fa667fdf5bc3e99f950eb08f7c42 and reverted in c90469b
Attempt to implement 'inherited' rcparams, that is rcparams that are only used if they are non-default. Re-introduces feature introduced in matplotlib#3792 /92e608d655f1fa667fdf5bc3e99f950eb08f7c42 and reverted in c90469b
Attempt to implement 'inherited' rcparams, that is rcparams that are only used if they are non-default. Re-introduces feature introduced in matplotlib#3792 /92e608d655f1fa667fdf5bc3e99f950eb08f7c42 and reverted in c90469b
Ref: #3785